Commit 14d755a4 authored Nov 02, 2020 by Vinay Kumar Yadav Committed by Greg Kroah-Hartman Nov 10, 2020

chelsio/chtls: fix memory leaks caused by a race



[ Upstream commit 8080b462b6aa856ae05ea010441a702599e579f2 ]

race between user context and softirq causing memleak,
consider the call sequence scenario

chtls_setkey()         //user context
chtls_peer_close()
chtls_abort_req_rss()
chtls_setkey()         //user context

work request skb queued in chtls_setkey() won't be freed
because resources are already cleaned for this connection,
fix it by not queuing work request while socket is closing.

v1->v2:
- fix W=1 warning.

v2->v3:
- separate it out from another memleak fix.

Fixes: cc35c88a ("crypto : chtls - CPL handler definition")
Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Link: https://lore.kernel.org/r/20201102173650.24754-1-vinay.yadav@chelsio.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 57bb59f9

drivers/crypto/chelsio/chtls/chtls_hw.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -357,6 +357,9 @@ int chtls_setkey(struct chtls_sock *csk, u32 keylen, u32 optname)
		if (ret)
		goto out_notcb;

		if (unlikely(csk_flag(sk, CSK_ABORT_SHUTDOWN)))
		goto out_notcb;

		set_wr_txq(skb, CPL_PRIORITY_DATA, csk->tlshws.txqid);
		csk->wr_credits -= DIV_ROUND_UP(len, 16);
		csk->wr_unacked += DIV_ROUND_UP(len, 16);