Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14b92470 authored by Timur Tabi's avatar Timur Tabi Committed by Benjamin Herrenschmidt
Browse files

powerpc/mpic: Add support for discontiguous cores 



There is one place in the MPIC driver that assumes that the cores are numbered
from 0 to n-1.  However, this is not true if the CPUs are not numbered
sequentially.  This can happen on a eight-core SOC where cores two and three
are removed in the device tree.  So instead of blindly looping, we iterate
over the discovered CPUs and use the SMP ID as the index.

This means that we no longer ask the MPIC how many CPUs there are, so
we also delete mpic->num_cpus.

We also catch if the number of CPUs in the SOC exceeds the number that the
MPIC supports.  This should never happen, of course, but it's good to be
sure.

Signed-off-by: default avatarTimur Tabi <timur@freescale.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 41151e77

arch/powerpc/include/asm/mpic.h

+0 −2
Original line number Diff line number Diff line
@@ -273,8 +273,6 @@ struct mpic 
	unsigned int		irq_count;

	/* Number of sources */

	unsigned int		num_sources;

	/* Number of CPUs */

	unsigned int		num_cpus;

	/* default senses array */

	unsigned char		*senses;

	unsigned int		senses_count;

arch/powerpc/sysdev/mpic.c

+15 −9
Original line number Diff line number Diff line
@@ -1285,13 +1285,11 @@ struct mpic * __init mpic_alloc(struct device_node *node, 
			   mpic_read(mpic->gregs, MPIC_INFO(GREG_GLOBAL_CONF_0))

			   | MPIC_GREG_GCONF_MCK);



	/* Read feature register, calculate num CPUs and, for non-ISU

	 * MPICs, num sources as well. On ISU MPICs, sources are counted

	 * as ISUs are added

	/*

	 * Read feature register.  For non-ISU MPICs, num sources as well. On

	 * ISU MPICs, sources are counted as ISUs are added

	 */

	greg_feature = mpic_read(mpic->gregs, MPIC_INFO(GREG_FEATURE_0));

	mpic->num_cpus = ((greg_feature & MPIC_GREG_FEATURE_LAST_CPU_MASK)

			  >> MPIC_GREG_FEATURE_LAST_CPU_SHIFT) + 1;

	if (isu_size == 0) {

		if (flags & MPIC_BROKEN_FRR_NIRQS)

			mpic->num_sources = mpic->irq_count;
@@ -1301,10 +1299,18 @@ struct mpic * __init mpic_alloc(struct device_node *node, 
				 >> MPIC_GREG_FEATURE_LAST_SRC_SHIFT) + 1;

	}



	/*

	 * The MPIC driver will crash if there are more cores than we

	 * can initialize, so we may as well catch that problem here.

	 */

	BUG_ON(num_possible_cpus() > MPIC_MAX_CPUS);



	/* Map the per-CPU registers */

	for (i = 0; i < mpic->num_cpus; i++) {

		mpic_map(mpic, node, paddr, &mpic->cpuregs[i],

			 MPIC_INFO(CPU_BASE) + i * MPIC_INFO(CPU_STRIDE),

	for_each_possible_cpu(i) {

		unsigned int cpu = get_hard_smp_processor_id(i);



		mpic_map(mpic, node, paddr, &mpic->cpuregs[cpu],

			 MPIC_INFO(CPU_BASE) + cpu * MPIC_INFO(CPU_STRIDE),

			 0x1000);

	}
@@ -1343,7 +1349,7 @@ struct mpic * __init mpic_alloc(struct device_node *node, 
	}

	printk(KERN_INFO "mpic: Setting up MPIC \"%s\" version %s at %llx,"

	       " max %d CPUs\n",

	       name, vers, (unsigned long long)paddr, mpic->num_cpus);

	       name, vers, (unsigned long long)paddr, num_possible_cpus());

	printk(KERN_INFO "mpic: ISU size: %d, shift: %d, mask: %x\n",

	       mpic->isu_size, mpic->isu_shift, mpic->isu_mask);