Commit 1464feb5 authored Dec 29, 2022 by Ben Dooks Committed by Greg Kroah-Hartman Jan 18, 2023

riscv: uaccess: fix type of 0 variable on error in get_user()



commit b9b916aee6715cd7f3318af6dc360c4729417b94 upstream.

If the get_user(x, ptr) has x as a pointer, then the setting
of (x) = 0 is going to produce the following sparse warning,
so fix this by forcing the type of 'x' when access_ok() fails.

fs/aio.c:2073:21: warning: Using plain integer as NULL pointer

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Link: https://lore.kernel.org/r/20221229170545.718264-1-ben-linux@fluff.org


Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent da41069c

arch/riscv/include/asm/uaccess.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -235,7 +235,7 @@ do { \
		might_fault(); \
		access_ok(__p, sizeof(*__p)) ? \
		__get_user((x), __p) : \
		((x) = 0, -EFAULT); \
		((x) = (__force __typeof__(x))0, -EFAULT); \
		})

		#define __put_user_asm(insn, x, ptr, err) \