Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13b5319e authored by Laura Abbott's avatar Laura Abbott Committed by Linus Walleij
Browse files

gpio: Remove VLA from xra1403 driver 

The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621

)

This patch replaces a VLA with an appropriate call to kmalloc_array.

Signed-off-by: default avatarLaura Abbott <labbott@redhat.com>
Reviewed-by: default avatarNandor Han <nandor.han@ge.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 48da181d

drivers/gpio/gpio-xra1403.c

+7 −1
Original line number Diff line number Diff line
@@ -126,11 +126,16 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip) 
{

	int reg;

	struct xra1403 *xra = gpiochip_get_data(chip);

	int value[xra1403_regmap_cfg.max_register];

	int *value;

	int i;

	unsigned int gcr;

	unsigned int gsr;



	value = kmalloc_array(xra1403_regmap_cfg.max_register, sizeof(*value),

				GFP_KERNEL);

	if (!value)

		return;



	seq_puts(s, "xra reg:");

	for (reg = 0; reg <= xra1403_regmap_cfg.max_register; reg++)

		seq_printf(s, " %2.2x", reg);
@@ -154,6 +159,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip) 
			   (gcr & BIT(i)) ? "in" : "out",

			   (gsr & BIT(i)) ? "hi" : "lo");

	}

	kfree(value);

}

#else

#define xra1403_dbg_show NULL