Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 135983e8 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: atmel-isi: Fix color component ordering 



The ISI_CFG2.YCC_SWAP field controls color component ordering. The
datasheet lists the following orderings for the memory formats.

YCC_SWAP	Byte 0	Byte 1	Byte 2	Byte 3
00: Default	Cb(i)	Y(i)	Cr(i)	Y(i+1)
01: Mode1	Cr(i)	Y(i)	Cb(i)	Y(i+1)
10: Mode2	Y(i)	Cb(i)	Y(i+1)	Cr(i)
11: Mode3	Y(i)	Cr(i)	Y(i+1)	Cb(i)

This is based on a sensor format set to CbYCrY (UYVY). The driver
hardcodes the output memory format to YUYV, configure the ordering
accordingly.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarJosh Wu <josh.wu@atmel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent f389e89c

drivers/media/platform/soc_camera/atmel-isi.c

+4 −4
Original line number Diff line number Diff line
@@ -112,16 +112,16 @@ static int configure_geometry(struct atmel_isi *isi, u32 width, 
	case V4L2_MBUS_FMT_Y8_1X8:

		cr = ISI_CFG2_GRAYSCALE;

		break;

	case V4L2_MBUS_FMT_UYVY8_2X8:

	case V4L2_MBUS_FMT_VYUY8_2X8:

		cr = ISI_CFG2_YCC_SWAP_MODE_3;

		break;

	case V4L2_MBUS_FMT_VYUY8_2X8:

	case V4L2_MBUS_FMT_UYVY8_2X8:

		cr = ISI_CFG2_YCC_SWAP_MODE_2;

		break;

	case V4L2_MBUS_FMT_YUYV8_2X8:

	case V4L2_MBUS_FMT_YVYU8_2X8:

		cr = ISI_CFG2_YCC_SWAP_MODE_1;

		break;

	case V4L2_MBUS_FMT_YVYU8_2X8:

	case V4L2_MBUS_FMT_YUYV8_2X8:

		cr = ISI_CFG2_YCC_SWAP_DEFAULT;

		break;

	/* RGB, TODO */