Commit 1356c177 authored Dec 01, 2022 by Valentina Goncharenko Committed by Greg Kroah-Hartman Dec 14, 2022

net: encx24j600: Add parentheses to fix precedence



[ Upstream commit 167b3f2dcc62c271f3555b33df17e361bb1fa0ee ]

In functions regmap_encx24j600_phy_reg_read() and
regmap_encx24j600_phy_reg_write() in the conditions of the waiting
cycles for filling the variable 'ret' it is necessary to add parentheses
to prevent wrong assignment due to logical operations precedence.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d70e5326 ("net: Microchip encx24j600 driver")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1831d454

drivers/net/ethernet/microchip/encx24j600-regmap.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -364,7 +364,7 @@ static int regmap_encx24j600_phy_reg_read(void *context, unsigned int reg,
		goto err_out;

		usleep_range(26, 100);
		while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) &&
		while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) &&
		(mistat & BUSY))
		cpu_relax();

		@@ -402,7 +402,7 @@ static int regmap_encx24j600_phy_reg_write(void *context, unsigned int reg,
		goto err_out;

		usleep_range(26, 100);
		while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) &&
		while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) &&
		(mistat & BUSY))
		cpu_relax();