Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13493ad6 authored by Tzung-Bi Shih's avatar Tzung-Bi Shih Committed by Greg Kroah-Hartman
Browse files

platform/chrome: cros_ec_chardev: fix kernel data leak from ioctl 

[ Upstream commit b20cf3f89c56b5f6a38b7f76a8128bf9f291bbd3 ]

It is possible to peep kernel page's data by providing larger `insize`
in struct cros_ec_command[1] when invoking EC host commands.

Fix it by using zeroed memory.

[1]: https://elixir.bootlin.com/linux/v6.2/source/include/linux/platform_data/cros_ec_proto.h#L74



Fixes: eda2e30c ("mfd / platform: cros_ec: Miscellaneous character device to talk with the EC")
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20230324010658.1082361-1-tzungbi@kernel.org


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a18fb433

drivers/platform/chrome/cros_ec_chardev.c

+1 −1
Original line number Diff line number Diff line
@@ -285,7 +285,7 @@ static long cros_ec_chardev_ioctl_xcmd(struct cros_ec_dev *ec, void __user *arg) 
	    u_cmd.insize > EC_MAX_MSG_BYTES)

		return -EINVAL;



	s_cmd = kmalloc(sizeof(*s_cmd) + max(u_cmd.outsize, u_cmd.insize),

	s_cmd = kzalloc(sizeof(*s_cmd) + max(u_cmd.outsize, u_cmd.insize),

			GFP_KERNEL);

	if (!s_cmd)

		return -ENOMEM;