Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 132fdc37 authored by Catalin Marinas's avatar Catalin Marinas Committed by Will Deacon
Browse files

arm64: Do not issue IPIs for user executable ptes 



Commit 3b8c9f1c ("arm64: IPI each CPU after invalidating the I-cache
for kernel mappings") was aimed at fixing the I-cache invalidation for
kernel mappings. However, it inadvertently caused all cache maintenance
for user mappings via set_pte_at() -> __sync_icache_dcache() ->
sync_icache_aliases() to call kick_all_cpus_sync().

Reported-by: default avatarShijith Thotton <sthotton@marvell.com>
Tested-by: default avatarShijith Thotton <sthotton@marvell.com>
Reported-by: default avatarWandun Chen <chenwandun@huawei.com>
Fixes: 3b8c9f1c ("arm64: IPI each CPU after invalidating the I-cache for kernel mappings")
Cc: <stable@vger.kernel.org> # 4.19.x-
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent f17b5f06

arch/arm64/mm/flush.c

+5 −1
Original line number Diff line number Diff line
@@ -33,7 +33,11 @@ void sync_icache_aliases(void *kaddr, unsigned long len) 
		__clean_dcache_area_pou(kaddr, len);

		__flush_icache_all();

	} else {

		flush_icache_range(addr, addr + len);

		/*

		 * Don't issue kick_all_cpus_sync() after I-cache invalidation

		 * for user mappings.

		 */

		__flush_icache_range(addr, addr + len);

	}

}