Commit 12e66ffb authored Jun 15, 2019 by Christian Lamparter Committed by Kalle Valo Jun 25, 2019

p54: remove dead branch in op_conf_tx callback



This patch removes the error branch for (queue > dev->queues).
It is no longer needed anymore as the "queue" value is validated by
cfg80211's parse_txq_params() before the driver code gets called.

Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 4a36de39

drivers/net/wireless/intersil/p54/main.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -414,12 +414,9 @@ static int p54_conf_tx(struct ieee80211_hw *dev,
		int ret;

		mutex_lock(&priv->conf_mutex);
		if (queue < dev->queues) {
		P54_SET_QUEUE(priv->qos_params[queue], params->aifs,
		params->cw_min, params->cw_max, params->txop);
		ret = p54_set_edcf(priv);
		} else
		ret = -EINVAL;
		mutex_unlock(&priv->conf_mutex);
		return ret;
		}