Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12de280b authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Martin K. Petersen
Browse files

scsi: smartpqi_init: fix boolean expression in pqi_device_remove_start 



Fix boolean expression by using logical AND operator '&&' instead of
bitwise operator '&'.

This issue was detected with the help of Coccinelle.

Fixes: 1e46731e ("scsi: smartpqi: check for null device pointers")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarDon Brace <don.brace@microsemi.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3f7e62bb

drivers/scsi/smartpqi/smartpqi_init.c

+1 −1
Original line number Diff line number Diff line
@@ -323,7 +323,7 @@ static inline void pqi_device_remove_start(struct pqi_scsi_dev *device) 
static inline bool pqi_device_in_remove(struct pqi_ctrl_info *ctrl_info,

					struct pqi_scsi_dev *device)

{

	return device->in_remove & !ctrl_info->in_shutdown;

	return device->in_remove && !ctrl_info->in_shutdown;

}



static inline void pqi_schedule_rescan_worker_with_delay(