Commit 12ca7297 authored Jul 17, 2019 by Li Jun Committed by Greg Kroah-Hartman Jul 30, 2019

usb: typec: tcpm: remove tcpm dir if no children



If config tcpm as module, module unload will not remove tcpm dir,
then the next module load will have problem: the rootdir is NULL
but tcpm dir is still there, so tcpm_debugfs_init() will create
tcpm dir again with failure, fix it by remove the tcpm dir if no
children.

Cc: stable@vger.kernel.org # v4.15+
Fixes: 4b4e02c8 ("typec: tcpm: Move out of staging")
Signed-off-by: Li Jun <jun.li@nxp.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20190717080646.30421-2-jun.li@nxp.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fd5da3e2

drivers/usb/typec/tcpm/tcpm.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -597,6 +597,10 @@ static void tcpm_debugfs_exit(struct tcpm_port *port)
		mutex_unlock(&port->logbuffer_lock);

		debugfs_remove(port->dentry);
		if (list_empty(&rootdir->d_subdirs)) {
		debugfs_remove(rootdir);
		rootdir = NULL;
		}
		}

		#else