Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12a0153f authored by Daniel Thompson's avatar Daniel Thompson Committed by Sasha Levin
Browse files

backlight: da9052: Fully initialize backlight_properties during probe 



[ Upstream commit 0285e9efaee8276305db5c52a59baf84e9731556 ]

props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!

Fixes: 6ede3d83 ("backlight: add driver for DA9052/53 PMIC v1")
Signed-off-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220153532.76613-2-daniel.thompson@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1c8d8c6b

drivers/video/backlight/da9052_bl.c

+1 −0
Original line number Diff line number Diff line
@@ -117,6 +117,7 @@ static int da9052_backlight_probe(struct platform_device *pdev) 
	wleds->led_reg = platform_get_device_id(pdev)->driver_data;

	wleds->state = DA9052_WLEDS_OFF;



	memset(&props, 0, sizeof(struct backlight_properties));

	props.type = BACKLIGHT_RAW;

	props.max_brightness = DA9052_MAX_BRIGHTNESS;