Commit 1229d433 authored Dec 26, 2020 by Dinghao Liu Committed by Greg Kroah-Hartman Jan 19, 2021

habanalabs: Fix memleak in hl_device_reset



[ Upstream commit b000700d6db50c933ce8b661154e26cf4ad06dba ]

When kzalloc() fails, we should execute hl_mmu_fini()
to release the MMU module. It's the same when
hl_ctx_init() fails.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 93aef8e6

drivers/misc/habanalabs/device.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -959,6 +959,7 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
		GFP_KERNEL);
		if (!hdev->kernel_ctx) {
		rc = -ENOMEM;
		hl_mmu_fini(hdev);
		goto out_err;
		}

		@@ -970,6 +971,7 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
		"failed to init kernel ctx in hard reset\n");
		kfree(hdev->kernel_ctx);
		hdev->kernel_ctx = NULL;
		hl_mmu_fini(hdev);
		goto out_err;
		}
		}