Commit 11edf0bb authored Jul 14, 2022 by Cheng Xu Committed by Greg Kroah-Hartman Aug 25, 2022

RDMA/siw: Fix duplicated reported IW_CM_EVENT_CONNECT_REPLY event

[ Upstream commit 3056fc6c32e613b760422b94c7617ac9a24a4721 ]

If siw_recv_mpa_rr returns -EAGAIN, it means that the MPA reply hasn't
been received completely, and should not report IW_CM_EVENT_CONNECT_REPLY
in this case. This may trigger a call trace in iw_cm. A simple way to
trigger this:
 server: ib_send_lat
 client: ib_send_lat -R <server_ip>

The call trace looks like this:

 kernel BUG at drivers/infiniband/core/iwcm.c:894!
 invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
 <...>
 Workqueue: iw_cm_wq cm_work_handler [iw_cm]
 Call Trace:
  <TASK>
  cm_work_handler+0x1dd/0x370 [iw_cm]
  process_one_work+0x1e2/0x3b0
  worker_thread+0x49/0x2e0
  ? rescuer_thread+0x370/0x370
  kthread+0xe5/0x110
  ? kthread_complete_and_exit+0x20/0x20
  ret_from_fork+0x1f/0x30
  </TASK>

Fixes: 6c52fdc2 ("rdma/siw: connection management")
Link: https://lore.kernel.org/r/dae34b5fd5c2ea2bd9744812c1d2653a34a94c67.1657706960.git.chengyou@linux.alibaba.com


Signed-off-by: Cheng Xu <chengyou@linux.alibaba.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fb9193af

drivers/infiniband/sw/siw/siw_cm.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -725,11 +725,11 @@ static int siw_proc_mpareply(struct siw_cep *cep)
		enum mpa_v2_ctrl mpa_p2p_mode = MPA_V2_RDMA_NO_RTR;

		rv = siw_recv_mpa_rr(cep);
		if (rv != -EAGAIN)
		siw_cancel_mpatimer(cep);
		if (rv)
		goto out_err;

		siw_cancel_mpatimer(cep);

		rep = &cep->mpa.hdr;

		if (__mpa_rr_revision(rep->params.bits) > MPA_REVISION_2) {
		@@ -895,6 +895,7 @@ static int siw_proc_mpareply(struct siw_cep *cep)
		}

		out_err:
		if (rv != -EAGAIN)
		siw_cm_upcall(cep, IW_CM_EVENT_CONNECT_REPLY, -EINVAL);

		return rv;