Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11af8474 authored by Josh Poimboeuf's avatar Josh Poimboeuf Committed by Ingo Molnar
Browse files

x86/unwind: Rename unwinder config options to 'CONFIG_UNWINDER_*' 



Rename the unwinder config options from:

  CONFIG_ORC_UNWINDER
  CONFIG_FRAME_POINTER_UNWINDER
  CONFIG_GUESS_UNWINDER

to:

  CONFIG_UNWINDER_ORC
  CONFIG_UNWINDER_FRAME_POINTER
  CONFIG_UNWINDER_GUESS

... in order to give them a more logical config namespace.

Suggested-by: default avatarIngo Molnar <mingo@kernel.org>
Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/73972fc7e2762e91912c6b9584582703d6f1b8cc.1507924831.git.jpoimboe@redhat.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 6edcf572

Documentation/x86/orc-unwinder.txt

+1 −1
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ ORC unwinder 
Overview

--------



The kernel CONFIG_ORC_UNWINDER option enables the ORC unwinder, which is

The kernel CONFIG_UNWINDER_ORC option enables the ORC unwinder, which is

similar in concept to a DWARF unwinder.  The difference is that the

format of the ORC data is much simpler than DWARF, which in turn allows

the ORC unwinder to be much simpler and faster.

Makefile

+2 −2
Original line number Diff line number Diff line
@@ -933,8 +933,8 @@ ifdef CONFIG_STACK_VALIDATION 
  ifeq ($(has_libelf),1)

    objtool_target := tools/objtool FORCE

  else

    ifdef CONFIG_ORC_UNWINDER

      $(error "Cannot generate ORC metadata for CONFIG_ORC_UNWINDER=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel")

    ifdef CONFIG_UNWINDER_ORC

      $(error "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel")

    else

      $(warning "Cannot use CONFIG_STACK_VALIDATION=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel")

    endif

arch/x86/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ config X86 
	select HAVE_PERF_USER_STACK_DUMP

	select HAVE_RCU_TABLE_FREE

	select HAVE_REGS_AND_STACK_ACCESS_API

	select HAVE_RELIABLE_STACKTRACE		if X86_64 && FRAME_POINTER_UNWINDER && STACK_VALIDATION

	select HAVE_RELIABLE_STACKTRACE		if X86_64 && UNWINDER_FRAME_POINTER && STACK_VALIDATION

	select HAVE_STACK_VALIDATION		if X86_64

	select HAVE_SYSCALL_TRACEPOINTS

	select HAVE_UNSTABLE_SCHED_CLOCK

arch/x86/Kconfig.debug

+5 −5
Original line number Diff line number Diff line
@@ -358,13 +358,13 @@ config PUNIT_ATOM_DEBUG 


choice

	prompt "Choose kernel unwinder"

	default FRAME_POINTER_UNWINDER

	default UNWINDER_FRAME_POINTER

	---help---

	  This determines which method will be used for unwinding kernel stack

	  traces for panics, oopses, bugs, warnings, perf, /proc/<pid>/stack,

	  livepatch, lockdep, and more.



config FRAME_POINTER_UNWINDER

config UNWINDER_FRAME_POINTER

	bool "Frame pointer unwinder"

	select FRAME_POINTER

	---help---
@@ -379,7 +379,7 @@ config FRAME_POINTER_UNWINDER 
	  consistency model, as this is currently the only way to get a

	  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).



config ORC_UNWINDER

config UNWINDER_ORC

	bool "ORC unwinder"

	depends on X86_64

	select STACK_VALIDATION
@@ -395,7 +395,7 @@ config ORC_UNWINDER 
	  Enabling this option will increase the kernel's runtime memory usage

	  by roughly 2-4MB, depending on your kernel config.



config GUESS_UNWINDER

config UNWINDER_GUESS

	bool "Guess unwinder"

	depends on EXPERT

	---help---
@@ -410,7 +410,7 @@ config GUESS_UNWINDER 
endchoice



config FRAME_POINTER

	depends on !ORC_UNWINDER && !GUESS_UNWINDER

	depends on !UNWINDER_ORC && !UNWINDER_GUESS

	bool



endmenu

arch/x86/configs/tiny.config

+2 −2
Original line number Diff line number Diff line 
CONFIG_NOHIGHMEM=y

# CONFIG_HIGHMEM4G is not set

# CONFIG_HIGHMEM64G is not set

CONFIG_GUESS_UNWINDER=y

# CONFIG_FRAME_POINTER_UNWINDER is not set
 
CONFIG_UNWINDER_GUESS=y

# CONFIG_UNWINDER_FRAME_POINTER is not set