Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 112c1af0 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Greg Kroah-Hartman
Browse files

wifi: ipw2200: fix memory leak in ipw_wdev_init() 



[ Upstream commit 9fe21dc626117fb44a8eb393713a86a620128ce3 ]

In the error path of ipw_wdev_init(), exception value is returned, and
the memory applied for in the function is not released. Also the memory
is not released in ipw_pci_probe(). As a result, memory leakage occurs.
So memory release needs to be added to the error path of ipw_wdev_init().

Fixes: a3caa99e ("libipw: initiate cfg80211 API conversion (v2)")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221209012422.182669-1-shaozhengchao@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ba1d3623

drivers/net/wireless/intel/ipw2x00/ipw2200.c

+7 −2
Original line number Diff line number Diff line
@@ -11414,9 +11414,14 @@ static int ipw_wdev_init(struct net_device *dev) 
	set_wiphy_dev(wdev->wiphy, &priv->pci_dev->dev);



	/* With that information in place, we can now register the wiphy... */

	if (wiphy_register(wdev->wiphy))

		rc = -EIO;

	rc = wiphy_register(wdev->wiphy);

	if (rc)

		goto out;



	return 0;

out:

	kfree(priv->ieee->a_band.channels);

	kfree(priv->ieee->bg_band.channels);

	return rc;

}