Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1107ca10 authored by Mathias Nyman's avatar Mathias Nyman Committed by Linus Walleij
Browse files

gpiolib-acpi: Fix error checks in interrupt requesting 



Print error message if requesting an interrupt fails.
Use int instead of unsigned for interrupts in case of error values

Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent de0ccf78

drivers/gpio/gpiolib-acpi.c

+7 −2
Original line number Diff line number Diff line
@@ -83,7 +83,8 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) 
	struct acpi_resource *res;

	acpi_handle handle, ev_handle;

	acpi_status status;

	unsigned int pin, irq;

	unsigned int pin;

	int irq, ret;

	char ev_name[5];



	if (!chip->dev || !chip->to_irq)
@@ -126,11 +127,15 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) 
			continue;



		/* Assume BIOS sets the triggering, so no flags */

		devm_request_threaded_irq(chip->dev, irq, NULL,

		ret = devm_request_threaded_irq(chip->dev, irq, NULL,

					  acpi_gpio_irq_handler,

					  0,

					  "GPIO-signaled-ACPI-event",

					  ev_handle);

		if (ret)

			dev_err(chip->dev,

				"Failed to request IRQ %d ACPI event handler\n",

				irq);

	}

}

EXPORT_SYMBOL(acpi_gpiochip_request_interrupts);