Commit 1105a13b authored Jun 14, 2013 by Alexey Khoroshilov Committed by John W. Linville Jun 14, 2013

orinoco_usb: fix memory leak in ezusb_access_ltv() when device disconnected

If "device is disconnected" check occurs to be true in ezusb_access_ltv(),
it just return -ENODEV. But that means request_context is leaked since
there are no any references to it anymore.
The patch adds a call to ezusb_request_context_put() before return.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 9b60b64b

drivers/net/wireless/orinoco/orinoco_usb.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -881,7 +881,8 @@ static int ezusb_access_ltv(struct ezusb_priv *upriv,

		if (!upriv->udev) {
		dbg("Device disconnected");
		return -ENODEV;
		retval = -ENODEV;
		goto exit;
		}

		if (upriv->read_urb->status != -EINPROGRESS)