Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 106204b5 authored by Kangjie Lu's avatar Kangjie Lu Committed by Mika Westerberg
Browse files

thunderbolt: property: Fix a NULL pointer dereference



In case kzalloc fails, the fix releases resources and returns
-ENOMEM to avoid the NULL pointer dereference.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 9e98c678
Loading
Loading
Loading
Loading
+5 −0
Original line number Diff line number Diff line
@@ -548,6 +548,11 @@ int tb_property_add_data(struct tb_property_dir *parent, const char *key,

	property->length = size / 4;
	property->value.data = kzalloc(size, GFP_KERNEL);
	if (!property->value.data) {
		kfree(property);
		return -ENOMEM;
	}

	memcpy(property->value.data, buf, buflen);

	list_add_tail(&property->list, &parent->properties);