Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 105eac6c authored by Bert Kenward's avatar Bert Kenward Committed by David S. Miller
Browse files

sfc: forget filters from sw table if hw replies ENOENT on removing them 



If the hw doesn't think they exist, we should defer to its authority.

Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0ccb998b

drivers/net/ethernet/sfc/ef10.c

+8 −3
Original line number Diff line number Diff line
@@ -4309,13 +4309,18 @@ static int efx_ef10_filter_remove_internal(struct efx_nic *efx, 
			       MC_CMD_FILTER_OP_IN_OP_UNSUBSCRIBE);

		MCDI_SET_QWORD(inbuf, FILTER_OP_IN_HANDLE,

			       table->entry[filter_idx].handle);

		rc = efx_mcdi_rpc(efx, MC_CMD_FILTER_OP,

		rc = efx_mcdi_rpc_quiet(efx, MC_CMD_FILTER_OP,

					inbuf, sizeof(inbuf), NULL, 0, NULL);



		spin_lock_bh(&efx->filter_lock);

		if (rc == 0) {

		if ((rc == 0) || (rc == -ENOENT)) {

			/* Filter removed OK or didn't actually exist */

			kfree(spec);

			efx_ef10_filter_set_entry(table, filter_idx, NULL, 0);

		} else {

			efx_mcdi_display_error(efx, MC_CMD_FILTER_OP,

					       MC_CMD_FILTER_OP_IN_LEN,

					       NULL, 0, rc);

		}

	}