Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1003201a authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

qlnic: fix a race in qlcnic_get_stats() 



Dont clear netdev->stats, it might give transient wrong values to
concurrent stat readers.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79c5f51c

drivers/net/qlcnic/qlcnic_main.c

+0 −2
Original line number Diff line number Diff line
@@ -1983,8 +1983,6 @@ static struct net_device_stats *qlcnic_get_stats(struct net_device *netdev) 
	struct qlcnic_adapter *adapter = netdev_priv(netdev);

	struct net_device_stats *stats = &netdev->stats;



	memset(stats, 0, sizeof(*stats));



	stats->rx_packets = adapter->stats.rx_pkts + adapter->stats.lro_pkts;

	stats->tx_packets = adapter->stats.xmitfinished;

	stats->rx_bytes = adapter->stats.rxbytes + adapter->stats.lrobytes;