Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ffb94b6 authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab
Browse files

[media] cxd2820r: fix gpio null pointer dereference 



Setting GPIOs during probe causes null pointer deference when
GPIOLIB was not selected by Kconfig. Initialize driver private
field before calling set gpios.

It is regressing bug since 4.9.

Fixes: 07fdf7d9 ("[media] cxd2820r: add I2C driver bindings")

Reported-by: default avatarChris Rankin <rankincj@gmail.com>
Tested-by: default avatarChris Rankin <rankincj@gmail.com>
Tested-by: default avatarHåkan Lennestål <hakan.lennestal@gmail.com>
Cc: <stable@vger.kernel.org> # v4.9+
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent d40e98c1

drivers/media/dvb-frontends/cxd2820r_core.c

+1 −1
Original line number Diff line number Diff line
@@ -615,6 +615,7 @@ static int cxd2820r_probe(struct i2c_client *client, 
	}



	priv->client[0] = client;

	priv->fe.demodulator_priv = priv;

	priv->i2c = client->adapter;

	priv->ts_mode = pdata->ts_mode;

	priv->ts_clk_inv = pdata->ts_clk_inv;
@@ -697,7 +698,6 @@ static int cxd2820r_probe(struct i2c_client *client, 
	memcpy(&priv->fe.ops, &cxd2820r_ops, sizeof(priv->fe.ops));

	if (!pdata->attach_in_use)

		priv->fe.ops.release = NULL;

	priv->fe.demodulator_priv = priv;

	i2c_set_clientdata(client, priv);



	/* Setup callbacks */