Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ff9f496 authored by John Garry's avatar John Garry Committed by Xinliang Liu
Browse files

drm/hisilicon: hibmc: Don't overwrite fb helper surface depth 



Currently the driver overwrites the surface depth provided by the fb
helper to give an invalid bpp/surface depth combination.

This has been exposed by commit 70109354 ("drm: Reject unknown legacy
bpp and depth for drm_mode_addfb ioctl"), which now causes the driver to
fail to probe.

Fix by not overwriting the surface depth.

Fixes: d1667b86 ("drm/hisilicon/hibmc: Add support for frame buffer")
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarXinliang Liu <z.liuxinliang@hisilicon.com>
Signed-off-by: default avatarXinliang Liu <z.liuxinliang@hisilicon.com>
parent 331d880b

drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c

+0 −1
Original line number Diff line number Diff line
@@ -71,7 +71,6 @@ static int hibmc_drm_fb_create(struct drm_fb_helper *helper, 
	DRM_DEBUG_DRIVER("surface width(%d), height(%d) and bpp(%d)\n",

			 sizes->surface_width, sizes->surface_height,

			 sizes->surface_bpp);

	sizes->surface_depth = 32;



	bytes_per_pixel = DIV_ROUND_UP(sizes->surface_bpp, 8);