Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fc645f3 authored by Daniele Ceraolo Spurio's avatar Daniele Ceraolo Spurio Committed by Chris Wilson
Browse files

drm/i915/guc: Don't clear the cookie on doorbell destroy 



If the HW has not processed the db invalidation request yet, clearing
the cookie can generate a db ring. We clear the cookie when we
(re-)allocate the doorbell so no need to do it on destroy as well as no
one is going to look at it while the doorbell is inactive

v2: fix typo in patch title (Michal)

Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20181002215430.15049-2-daniele.ceraolospurio@intel.com
parent 48b426a9

drivers/gpu/drm/i915/intel_guc_submission.c

+0 −1
Original line number Diff line number Diff line
@@ -209,7 +209,6 @@ static void __destroy_doorbell(struct intel_guc_client *client) 


	doorbell = __get_doorbell(client);

	doorbell->db_status = GUC_DOORBELL_DISABLED;

	doorbell->cookie = 0;



	/* Doorbell release flow requires that we wait for GEN8_DRB_VALID bit

	 * to go to zero after updating db_status before we call the GuC to