Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f94cd0e authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Greg Kroah-Hartman
Browse files

dm persistent data: fix memory allocation failure 



commit faada2174c08662ae98b439c69efe3e79382c538 upstream.

kmalloc is unreliable when allocating more than 8 pages of memory. It may
fail when there is plenty of free memory but the memory is fragmented.
Zdenek Kabelac observed such failure in his tests.

This commit changes kmalloc to kvmalloc - kvmalloc will fall back to
vmalloc if the large allocation fails.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Reported-by: default avatarZdenek Kabelac <zkabelac@redhat.com>
Reviewed-by: default avatarMike Snitzer <snitzer@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f75dec84

drivers/md/persistent-data/dm-space-map-metadata.c

+2 −2
Original line number Diff line number Diff line
@@ -275,7 +275,7 @@ static void sm_metadata_destroy(struct dm_space_map *sm) 
{

	struct sm_metadata *smm = container_of(sm, struct sm_metadata, sm);



	kfree(smm);

	kvfree(smm);

}



static int sm_metadata_get_nr_blocks(struct dm_space_map *sm, dm_block_t *count)
@@ -759,7 +759,7 @@ struct dm_space_map *dm_sm_metadata_init(void) 
{

	struct sm_metadata *smm;



	smm = kmalloc(sizeof(*smm), GFP_KERNEL);

	smm = kvmalloc(sizeof(*smm), GFP_KERNEL);

	if (!smm)

		return ERR_PTR(-ENOMEM);