Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f132ba7 authored by Wen Gong's avatar Wen Gong Committed by Kalle Valo
Browse files

ath10k: add support for firmware crash recovery on SDIO chip 



The command to simulate firmware crash:
echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash

It will send WMI_FORCE_FW_HANG_ASSERT to firmware, then it will trigger
CPU interrupt status register for SDIO chip, ath10k driver need to
configure it while enable SDIO interrupt, otherwise ath10k driver will
not get the assert error info.

After this change, it will success for simulate firmware crash.

Tested with QCA6174 SDIO with firmware
WLAN.RMH.4.4.1-00007-QCARMSWP-1.

Signed-off-by: default avatarWen Gong <wgong@codeaurora.org>
Tested-by: default avatarClaire Chang <tientzu@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 9d740d63

drivers/net/wireless/ath/ath10k/hw.h

+1 −0
Original line number Diff line number Diff line
@@ -1101,6 +1101,7 @@ ath10k_is_rssi_enable(struct ath10k_hw_params *hw, 
#define MBOX_CPU_INT_STATUS_ENABLE_ADDRESS	0x00000819

#define MBOX_CPU_INT_STATUS_ENABLE_BIT_LSB	0

#define MBOX_CPU_INT_STATUS_ENABLE_BIT_MASK	0x000000ff

#define MBOX_CPU_STATUS_ENABLE_ASSERT_MASK 0x00000001

#define MBOX_ERROR_STATUS_ENABLE_ADDRESS	0x0000081a

#define MBOX_ERROR_STATUS_ENABLE_RX_UNDERFLOW_LSB  1

#define MBOX_ERROR_STATUS_ENABLE_RX_UNDERFLOW_MASK 0x00000002

drivers/net/wireless/ath/ath10k/sdio.c

+8 −2
Original line number Diff line number Diff line
@@ -855,6 +855,10 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar) 


out:

	mutex_unlock(&irq_data->mtx);

	if (cpu_int_status & MBOX_CPU_STATUS_ENABLE_ASSERT_MASK) {

		ath10k_err(ar, "firmware crashed!\n");

		queue_work(ar->workqueue, &ar->restart_work);

	}

	return ret;

}
@@ -1500,8 +1504,10 @@ static int ath10k_sdio_hif_enable_intrs(struct ath10k *ar) 
	regs->int_status_en |=

		FIELD_PREP(MBOX_INT_STATUS_ENABLE_MBOX_DATA_MASK, 1);



	/* Set up the CPU Interrupt status Register */

	regs->cpu_int_status_en = 0;

	/* Set up the CPU Interrupt Status Register, enable CPU sourced interrupt #0

	 * #0 is used for report assertion from target

	 */

	regs->cpu_int_status_en = FIELD_PREP(MBOX_CPU_STATUS_ENABLE_ASSERT_MASK, 1);



	/* Set up the Error Interrupt status Register */

	regs->err_int_status_en =