Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ef7528d authored by Baoyou Xie's avatar Baoyou Xie Committed by Greg Kroah-Hartman
Browse files

coresight: tmc: mark symbols static where possible 



We get a few warnings when building kernel with W=1:
drivers/hwtracing/coresight/coresight-tmc-etr.c:23:6: warning: no previous prototype for 'tmc_etr_enable_hw' [-Wmissing-prototypes]
drivers/hwtracing/coresight/coresight-tmc-etf.c:25:6: warning: no previous prototype for 'tmc_etb_enable_hw' [-Wmissing-prototypes]
drivers/hwtracing/coresight/coresight-tmc.c:250:9: warning: no previous prototype for ‘trigger_cntr_show’ [-Wmissing-prototypes]
...

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.

Signed-off-by: default avatarBaoyou Xie <baoyou.xie@linaro.org>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8e67cdbc

drivers/hwtracing/coresight/coresight-tmc-etf.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -22,7 +22,7 @@ 
#include "coresight-priv.h"

#include "coresight-priv.h"

#include "coresight-tmc.h"

#include "coresight-tmc.h"





void tmc_etb_enable_hw(struct tmc_drvdata *drvdata)

static void tmc_etb_enable_hw(struct tmc_drvdata *drvdata)

{

{

	CS_UNLOCK(drvdata->base);

	CS_UNLOCK(drvdata->base);

drivers/hwtracing/coresight/coresight-tmc-etr.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -20,7 +20,7 @@ 
#include "coresight-priv.h"

#include "coresight-priv.h"

#include "coresight-tmc.h"

#include "coresight-tmc.h"





void tmc_etr_enable_hw(struct tmc_drvdata *drvdata)

static void tmc_etr_enable_hw(struct tmc_drvdata *drvdata)

{

{

	u32 axictl;

	u32 axictl;

drivers/hwtracing/coresight/coresight-tmc.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -247,7 +247,7 @@ static struct attribute *coresight_tmc_mgmt_attrs[] = { 
	NULL,

	NULL,

};

};





ssize_t trigger_cntr_show(struct device *dev,

static ssize_t trigger_cntr_show(struct device *dev,

				 struct device_attribute *attr, char *buf)

				 struct device_attribute *attr, char *buf)

{

{

	struct tmc_drvdata *drvdata = dev_get_drvdata(dev->parent);

	struct tmc_drvdata *drvdata = dev_get_drvdata(dev->parent);