Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0eed84ff authored by Kees Cook's avatar Kees Cook
Browse files

pstore: Improve and update some comments and status output 



This improves and updates some comments:
 - dump handler comment out of sync from calling convention
 - fix kern-doc typo

and improves status output:
 - reminder that only kernel crash dumps are compressed
 - do not be silent about ECC infrastructure failures

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent c208f7d4

fs/pstore/platform.c

+3 −4
Original line number Diff line number Diff line
@@ -304,7 +304,7 @@ static void allocate_buf_for_compression(void) 
	big_oops_buf_sz = size;

	big_oops_buf = buf;



	pr_info("Using compression: %s\n", zbackend->name);

	pr_info("Using crash dump compression: %s\n", zbackend->name);

}



static void free_buf_for_compression(void)
@@ -354,9 +354,8 @@ void pstore_record_init(struct pstore_record *record, 
}



/*

 * callback from kmsg_dump. (s2,l2) has the most recently

 * written bytes, older bytes are in (s1,l1). Save as much

 * as we can from the end of the buffer.

 * callback from kmsg_dump. Save as much as we can (up to kmsg_bytes) from the

 * end of the buffer.

 */

static void pstore_dump(struct kmsg_dumper *dumper,

			enum kmsg_dump_reason reason)

fs/pstore/ram_core.c

+3 −1
Original line number Diff line number Diff line
@@ -503,8 +503,10 @@ static int persistent_ram_post_init(struct persistent_ram_zone *prz, u32 sig, 
	bool zap = !!(prz->flags & PRZ_FLAG_ZAP_OLD);



	ret = persistent_ram_init_ecc(prz, ecc_info);

	if (ret)

	if (ret) {

		pr_warn("ECC failed %s\n", prz->label);

		return ret;

	}



	sig ^= PERSISTENT_RAM_SIG;

include/linux/pstore.h

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ struct pstore_record { 
/**

 * struct pstore_info - backend pstore driver structure

 *

 * @owner:	module which is repsonsible for this backend driver

 * @owner:	module which is responsible for this backend driver

 * @name:	name of the backend driver

 *

 * @buf_lock:	spinlock to serialize access to @buf