Commit 0ed75931 authored Dec 07, 2020 by Veera Vegivada Committed by Gerrit - the friendly Code Review server Dec 12, 2020

scsi: ufs: Fix IOCTL error checking for input buffer



The check for user buffer != NULL in ufshcd_ioctl() should
only be done at a point when we know we have a valid IOCTL
command.  Move this check inside the UFS_IOCTL_QUERY
handling code.

Change-Id: I10e86b30ae1fdd8c9230db476bb593ccfa94b55c
Signed-off-by: Anjana <ahari@codeaurora.org>
Signed-off-by: Veera Vegivada <vvegivad@codeaurora.org>

parent aa860b5b

drivers/scsi/ufs/ufs-qcom.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -2403,13 +2403,13 @@ ufs_qcom_ioctl(struct scsi_device dev, unsigned int cmd, void __user buffer)
		int err = 0;

		BUG_ON(!hba);

		switch (cmd) {
		case UFS_IOCTL_QUERY:
		if (!buffer) {
		dev_err(hba->dev, "%s: User buffer is NULL!\n", __func__);
		return -EINVAL;
		}

		switch (cmd) {
		case UFS_IOCTL_QUERY:
		pm_runtime_get_sync(hba->dev);
		err = ufs_qcom_query_ioctl(hba,
		ufshcd_scsi_to_upiu_lun(dev->lun),