Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ed65ad5 authored by Vulupala Shashank Reddy's avatar Vulupala Shashank Reddy Committed by Madan Koyyalamudi
Browse files

qcacld-3.0: Fix vdev reference count in packet capture 

In pkt_capture_datapkt_process and pkt_capture_mgmt_rx_data_cb
pkt_capture_vdev_put_ref is missing in error case, because of
which vdev ref count is not becoming zero when vdev is down.

Add pkt_capture_vdev_put_ref in all the error cases.

Change-Id: I55353356f059a367d57c64625f404e3940235be1
CRs-Fixed: 3228599
parent 78e6a7fe

components/pkt_capture/core/src/wlan_pkt_capture_data_txrx.c

+8 −5
Original line number Diff line number Diff line
@@ -1467,10 +1467,6 @@ void pkt_capture_datapkt_process( 
	if (QDF_IS_STATUS_ERROR(ret))

		goto drop_rx_buf;



	pkt = pkt_capture_alloc_mon_pkt(vdev);

	if (!pkt)

		goto drop_rx_buf;



	switch (type) {

	case TXRX_PROCESS_TYPE_DATA_RX:

		callback = pkt_capture_rx_data_cb;
@@ -1480,7 +1476,14 @@ void pkt_capture_datapkt_process( 
		callback = pkt_capture_tx_data_cb;

		break;

	default:

		return;

		pkt_capture_vdev_put_ref(vdev);

		goto drop_rx_buf;

	}



	pkt = pkt_capture_alloc_mon_pkt(vdev);

	if (!pkt) {

		pkt_capture_vdev_put_ref(vdev);

		goto drop_rx_buf;

	}



	pkt->callback = callback;

components/pkt_capture/core/src/wlan_pkt_capture_mgmt_txrx.c

+1 −0
Original line number Diff line number Diff line
@@ -594,6 +594,7 @@ pkt_capture_mgmt_rx_data_cb(struct wlan_objmgr_psoc *psoc, 
				  buf_len + RESERVE_BYTES, 4),

				  RESERVE_BYTES, 4, false);

	if (!nbuf) {

		pkt_capture_vdev_put_ref(vdev);

		qdf_nbuf_free(wbuf);

		return QDF_STATUS_E_FAILURE;

	}