Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0eac9aba authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Luca Coelho
Browse files

iwlwifi: mvm: fix TSO with highly fragmented SKBs 

Our hardware has a limited amount of buffer descriptors
for each Tx packet. Because of that, there is a short
piece of code that makes sure that that we don't push too
many subframes in an A-MSDU because of subframes needs 2
buffer descriptors. This code also takes into account the
number of fragment of the skb since we also need a buffer
descriptor for each fragment in the skb.

This piece of code though didn't check that the resulting
number of subframes wasn't 0.

A user reported that using NFS client, he could get skbs
that are so fragmented that the code mentioned above
returned 0 for the number of subframes making
skb_gso_segment fail and subconsequently iwlwifi would WARN.

Fix this by make sure that num_subframes is at least 1.

This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=199209



Fixes: a6d5e32f ("iwlwifi: mvm: send large SKBs to the transport")
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 15c4e330

drivers/net/wireless/intel/iwlwifi/mvm/tx.c

+6 −6
Original line number Diff line number Diff line
@@ -843,8 +843,6 @@ static int iwl_mvm_tx_tso(struct iwl_mvm *mvm, struct sk_buff *skb, 
	 * N * subf_len + (N - 1) * pad.

	 */

	num_subframes = (max_amsdu_len + pad) / (subf_len + pad);

	if (num_subframes > 1)

		*ieee80211_get_qos_ctl(hdr) |= IEEE80211_QOS_CTL_A_MSDU_PRESENT;



	tcp_payload_len = skb_tail_pointer(skb) - skb_transport_header(skb) -

		tcp_hdrlen(skb) + skb->data_len;
@@ -855,10 +853,12 @@ static int iwl_mvm_tx_tso(struct iwl_mvm *mvm, struct sk_buff *skb, 
	 *	1 more for each fragment

	 *	1 more for the potential data in the header

	 */

	num_subframes =

		min_t(unsigned int, num_subframes,

		      (mvm->trans->max_skb_frags - 1 -

		       skb_shinfo(skb)->nr_frags) / 2);

	if ((num_subframes * 2 + skb_shinfo(skb)->nr_frags + 1) >

	    mvm->trans->max_skb_frags)

		num_subframes = 1;



	if (num_subframes > 1)

		*ieee80211_get_qos_ctl(hdr) |= IEEE80211_QOS_CTL_A_MSDU_PRESENT;



	/* This skb fits in one single A-MSDU */

	if (num_subframes * mss >= tcp_payload_len) {