Commit 0ea58b9b authored Oct 28, 2021 by Marek Behún Committed by Greg Kroah-Hartman Nov 17, 2021

PCI: aardvark: Fix return value of MSI domain .alloc() method

commit e4313be1599d397625c14fb7826996813622decf upstream.

MSI domain callback .alloc() (implemented by advk_msi_irq_domain_alloc()
function) should return zero on success, since non-zero value indicates
failure.

When the driver was converted to generic MSI API in commit f21a8b1b
("PCI: aardvark: Move to MSI handling using generic MSI support"), it
was converted so that it returns hwirq number.

Fix this.

Link: https://lore.kernel.org/r/20211028185659.20329-3-kabel@kernel.org


Fixes: f21a8b1b ("PCI: aardvark: Move to MSI handling using generic MSI support")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ee9cdca4

drivers/pci/controller/pci-aardvark.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -942,7 +942,7 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain,
		domain->host_data, handle_simple_irq,
		NULL, NULL);

		return hwirq;
		return 0;
		}

		static void advk_msi_irq_domain_free(struct irq_domain *domain,