Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e96460e authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

hv_netvsc: pass netvsc_device to rndis halt 



The caller has a valid pointer, pass it to rndis_filter_halt_device
and avoid any possible RCU races here.

Signed-off-by: default avatarStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a3a41d2f

drivers/net/hyperv/rndis_filter.c

+3 −4
Original line number Diff line number Diff line
@@ -944,12 +944,11 @@ static bool netvsc_device_idle(const struct netvsc_device *nvdev) 
	return true;

}



static void rndis_filter_halt_device(struct rndis_device *dev)

static void rndis_filter_halt_device(struct netvsc_device *nvdev,

				     struct rndis_device *dev)

{

	struct rndis_request *request;

	struct rndis_halt_request *halt;

	struct net_device_context *net_device_ctx = netdev_priv(dev->ndev);

	struct netvsc_device *nvdev = rtnl_dereference(net_device_ctx->nvdev);



	/* Attempt to do a rndis device halt */

	request = get_rndis_request(dev, RNDIS_MSG_HALT,
@@ -1348,7 +1347,7 @@ void rndis_filter_device_remove(struct hv_device *dev, 
	cancel_work_sync(&net_dev->subchan_work);



	/* Halt and release the rndis device */

	rndis_filter_halt_device(rndis_dev);

	rndis_filter_halt_device(net_dev, rndis_dev);



	net_dev->extension = NULL;