Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 0e36f36b authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: soc-core: fix module_put() warning in soc_cleanup_component 



The recent changes introduce warnings in the SOF load/unload module
tests. The code does not seem balanced with a confusion between
_close() and _remove() macros. Using _remove() fixes the issue and
removes the warning.

Suggested-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Fixes: 4a81e8f3 ('ASoC: soc-component: add snd_soc_component_get/put()')
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20190808025131.32482-1-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 596becd3

sound/soc/soc-core.c

+1 −1
Original line number Diff line number Diff line
@@ -935,7 +935,7 @@ static void soc_cleanup_component(struct snd_soc_component *component) 
	snd_soc_dapm_free(snd_soc_component_get_dapm(component));

	soc_cleanup_component_debugfs(component);

	component->card = NULL;

	snd_soc_component_module_put_when_close(component);

	snd_soc_component_module_put_when_remove(component);

}



static void soc_remove_component(struct snd_soc_component *component)