Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e21311b authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

net: bgmac: Fix an erroneous kfree() in bgmac_remove() 



[ Upstream commit d7dd6eccfbc95ac47a12396f84e7e1b361db654b ]

'bgmac' is part of a managed resource allocated with bgmac_alloc(). It
should not be freed explicitly.

Remove the erroneous kfree() from the .remove() function.

Fixes: 34a5102c ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/a026153108dd21239036a032b95c25b5cece253b.1655153616.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c19cdd72

drivers/net/ethernet/broadcom/bgmac-bcma.c

+0 −1
Original line number Diff line number Diff line
@@ -323,7 +323,6 @@ static void bgmac_remove(struct bcma_device *core) 
	bcma_mdio_mii_unregister(bgmac->mii_bus);

	bgmac_enet_remove(bgmac);

	bcma_set_drvdata(core, NULL);

	kfree(bgmac);

}



static struct bcma_driver bgmac_bcma_driver = {