Commit 0e0d5002 authored Feb 27, 2018 by Pablo Neira Ayuso

netfilter: nf_tables: use the right index from flowtable error path



Use the right loop index, not the number of devices in the array that we
need to remove, the following message uncovered the problem:

[ 5437.044119] hook not found, pf 5 num 0
[ 5437.044140] WARNING: CPU: 2 PID: 24983 at net/netfilter/core.c:376 __nf_unregister_net_hook+0x250/0x280

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent e603ea4b

net/netfilter/nf_tables_api.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5136,7 +5136,7 @@ static int nf_tables_newflowtable(struct net net, struct sock nlsk,
		i = flowtable->ops_len;
		err4:
		for (k = i - 1; k >= 0; k--)
		nf_unregister_net_hook(net, &flowtable->ops[i]);
		nf_unregister_net_hook(net, &flowtable->ops[k]);

		kfree(flowtable->ops);
		err3: