Commit 0de27884 authored Dec 04, 2016 by Pan Bian Committed by Borislav Petkov Dec 04, 2016

EDAC, amd64: Fix improper return value

When the call to zalloc_cpumask_var() fails, returning "false" seems
improper. The real value of macro "false" is 0, and 0 means no error.
Return -ENOMEM instead.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071



Signed-off-by: Pan Bian <bianpan2016@163.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1480831638-5361-1-git-send-email-bianpan201604@163.com


Signed-off-by: Borislav Petkov <bp@suse.de>

parent 5246c540

drivers/edac/amd64_edac.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2913,7 +2913,7 @@ static int toggle_ecc_err_reporting(struct ecc_settings *s, u16 nid, bool on)

		if (!zalloc_cpumask_var(&cmask, GFP_KERNEL)) {
		amd64_warn("%s: error allocating mask\n", __func__);
		return false;
		return -ENOMEM;
		}

		get_cpus_on_this_dct_cpumask(cmask, nid);