Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0dbe15f8 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: ohci: beautify some macro definitions 



a) Sort device IDs by vendor -- device -- revision.

b) Write quirk flags in hexadecimal.  This affects the user-visible
output of "modinfo firewire-ohci".  Since more flags have been added
recently, it is now easier to cope with them in hexadecimal represen-
tation.  Besides, the device-specific combination of quirk flags is
shown in hexadecimal in the kernel log too.  (And firewire-sbp2
presents its own quirk flags in modinfo as hexadecimals as well.)

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent af53122a

drivers/firewire/ohci.c

+9 −9
Original line number Diff line number Diff line
@@ -271,6 +271,7 @@ static inline struct fw_ohci *fw_ohci(struct fw_card *card) 


static char ohci_driver_name[] = KBUILD_MODNAME;



#define PCI_VENDOR_ID_PINNACLE_SYSTEMS	0x11bd

#define PCI_DEVICE_ID_AGERE_FW643	0x5901

#define PCI_DEVICE_ID_CREATIVE_SB1394	0x4001

#define PCI_DEVICE_ID_JMICRON_JMB38X_FW	0x2380
@@ -278,17 +279,16 @@ static char ohci_driver_name[] = KBUILD_MODNAME; 
#define PCI_DEVICE_ID_TI_TSB12LV26	0x8020

#define PCI_DEVICE_ID_TI_TSB82AA2	0x8025

#define PCI_DEVICE_ID_VIA_VT630X	0x3044

#define PCI_VENDOR_ID_PINNACLE_SYSTEMS	0x11bd

#define PCI_REV_ID_VIA_VT6306		0x46



#define QUIRK_CYCLE_TIMER		1

#define QUIRK_RESET_PACKET		2

#define QUIRK_BE_HEADERS		4

#define QUIRK_NO_1394A			8

#define QUIRK_NO_MSI			16

#define QUIRK_TI_SLLZ059		32

#define QUIRK_IR_WAKE			64

#define QUIRK_PHY_LCTRL_TIMEOUT		128

#define QUIRK_CYCLE_TIMER		0x1

#define QUIRK_RESET_PACKET		0x2

#define QUIRK_BE_HEADERS		0x4

#define QUIRK_NO_1394A			0x8

#define QUIRK_NO_MSI			0x10

#define QUIRK_TI_SLLZ059		0x20

#define QUIRK_IR_WAKE			0x40

#define QUIRK_PHY_LCTRL_TIMEOUT		0x80



/* In case of multiple matches in ohci_quirks[], only the first one is used. */

static const struct {