Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0dad87fc authored by Markus Elfring's avatar Markus Elfring Committed by Tyler Hicks
Browse files

eCryptfs: Delete a check before the function call "key_put" 



The key_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around this call might not be needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTyler Hicks <tyhicks@canonical.com>
parent 5556e7e6

fs/ecryptfs/crypto.c

+1 −2
Original line number Diff line number Diff line
@@ -258,8 +258,7 @@ void ecryptfs_destroy_mount_crypt_stat( 
				 &mount_crypt_stat->global_auth_tok_list,

				 mount_crypt_stat_list) {

		list_del(&auth_tok->mount_crypt_stat_list);

		if (auth_tok->global_auth_tok_key

		    && !(auth_tok->flags & ECRYPTFS_AUTH_TOK_INVALID))

		if (!(auth_tok->flags & ECRYPTFS_AUTH_TOK_INVALID))

			key_put(auth_tok->global_auth_tok_key);

		kmem_cache_free(ecryptfs_global_auth_tok_cache, auth_tok);

	}