Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d04d0c1 authored by Lokesh Vutla's avatar Lokesh Vutla Committed by Marc Zyngier
Browse files

gpio: thunderx: Use the default parent apis for {request,release}_resources 



thunderx_gpio_irq_{request,release}_resources apis are trying to
{request,release} resources on parent interrupt. There are default
apis doing the same. Use the default parent apis instead of writing
the same code snippet.

Cc: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 2bd1298a

drivers/gpio/gpio-thunderx.c

+4 −12
Original line number Diff line number Diff line
@@ -363,22 +363,16 @@ static int thunderx_gpio_irq_request_resources(struct irq_data *data) 
{

	struct thunderx_line *txline = irq_data_get_irq_chip_data(data);

	struct thunderx_gpio *txgpio = txline->txgpio;

	struct irq_data *parent_data = data->parent_data;

	int r;



	r = gpiochip_lock_as_irq(&txgpio->chip, txline->line);

	if (r)

		return r;



	if (parent_data && parent_data->chip->irq_request_resources) {

		r = parent_data->chip->irq_request_resources(parent_data);

	r = irq_chip_request_resources_parent(data);

	if (r)

			goto error;

	}



	return 0;

error:

		gpiochip_unlock_as_irq(&txgpio->chip, txline->line);



	return r;

}
@@ -386,10 +380,8 @@ static void thunderx_gpio_irq_release_resources(struct irq_data *data) 
{

	struct thunderx_line *txline = irq_data_get_irq_chip_data(data);

	struct thunderx_gpio *txgpio = txline->txgpio;

	struct irq_data *parent_data = data->parent_data;



	if (parent_data && parent_data->chip->irq_release_resources)

		parent_data->chip->irq_release_resources(parent_data);

	irq_chip_release_resources_parent(data);



	gpiochip_unlock_as_irq(&txgpio->chip, txline->line);

}