Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0cd05062 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

misc: ocxl: fix possible name leak in ocxl_file_register_afu() 



[ Upstream commit a4cb1004aeed2ab893a058fad00a5b41a12c4691 ]

If device_register() returns error in ocxl_file_register_afu(),
the name allocated by dev_set_name() need be freed. As comment
of device_register() says, it should use put_device() to give
up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanup(),
and info is freed in info_release().

Fixes: 75ca758a ("ocxl: Create a clear delineation between ocxl backend & frontend")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Acked-by: default avatarAndrew Donnellan <ajd@linux.ibm.com>
Acked-by: default avatarFrederic Barrat <fbarrat@linux.ibm.com>
Link: https://lore.kernel.org/r/20221111145929.2429271-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 628de998

drivers/misc/ocxl/file.c

+5 −2
Original line number Diff line number Diff line
@@ -543,8 +543,11 @@ int ocxl_file_register_afu(struct ocxl_afu *afu) 
		goto err_put;



	rc = device_register(&info->dev);

	if (rc)

		goto err_put;

	if (rc) {

		free_minor(info);

		put_device(&info->dev);

		return rc;

	}



	rc = ocxl_sysfs_register_afu(info);

	if (rc)