Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c6df536 authored by Lucas Stach's avatar Lucas Stach Committed by Greg Kroah-Hartman
Browse files

drm/etnaviv: fix reference leak when mmaping imported buffer 



commit 963b2e8c428f79489ceeb058e8314554ec9cbe6f upstream.

drm_gem_prime_mmap() takes a reference on the GEM object, but before that
drm_gem_mmap_obj() already takes a reference, which will be leaked as only
one reference is dropped when the mapping is closed. Drop the extra
reference when dma_buf_mmap() succeeds.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarChristian Gmeiner <christian.gmeiner@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 37958ac3

drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c

+9 −1
Original line number Diff line number Diff line
@@ -93,7 +93,15 @@ static void *etnaviv_gem_prime_vmap_impl(struct etnaviv_gem_object *etnaviv_obj) 
static int etnaviv_gem_prime_mmap_obj(struct etnaviv_gem_object *etnaviv_obj,

		struct vm_area_struct *vma)

{

	return dma_buf_mmap(etnaviv_obj->base.dma_buf, vma, 0);

	int ret;



	ret = dma_buf_mmap(etnaviv_obj->base.dma_buf, vma, 0);

	if (!ret) {

		/* Drop the reference acquired by drm_gem_mmap_obj(). */

		drm_gem_object_put(&etnaviv_obj->base);

	}



	return ret;

}



static const struct etnaviv_gem_ops etnaviv_gem_prime_ops = {