Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c5bbeb8 authored by Todd Fujinaka's avatar Todd Fujinaka Committed by Jeff Kirsher
Browse files

igb: report unsupported ethtool settings in set_coalesce 



There are many settings possible using ethtool -C/--coalesce, but not
all of them are supported in igb. Report failure when an unsupported
option is set.

Signed-off-by: default avatarTodd Fujinaka <todd.fujinaka@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 7faae964

drivers/net/ethernet/intel/igb/igb_ethtool.c

+21 −0
Original line number Diff line number Diff line
@@ -2159,6 +2159,27 @@ static int igb_set_coalesce(struct net_device *netdev, 
	struct igb_adapter *adapter = netdev_priv(netdev);

	int i;



	if (ec->rx_max_coalesced_frames ||

	    ec->rx_coalesce_usecs_irq ||

	    ec->rx_max_coalesced_frames_irq ||

	    ec->tx_max_coalesced_frames ||

	    ec->tx_coalesce_usecs_irq ||

	    ec->stats_block_coalesce_usecs ||

	    ec->use_adaptive_rx_coalesce ||

	    ec->use_adaptive_tx_coalesce ||

	    ec->pkt_rate_low ||

	    ec->rx_coalesce_usecs_low ||

	    ec->rx_max_coalesced_frames_low ||

	    ec->tx_coalesce_usecs_low ||

	    ec->tx_max_coalesced_frames_low ||

	    ec->pkt_rate_high ||

	    ec->rx_coalesce_usecs_high ||

	    ec->rx_max_coalesced_frames_high ||

	    ec->tx_coalesce_usecs_high ||

	    ec->tx_max_coalesced_frames_high ||

	    ec->rate_sample_interval)

		return -ENOTSUPP;



	if ((ec->rx_coalesce_usecs > IGB_MAX_ITR_USECS) ||

	    ((ec->rx_coalesce_usecs > 3) &&

	     (ec->rx_coalesce_usecs < IGB_MIN_ITR_USECS)) ||