Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c399077 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by Greg Kroah-Hartman
Browse files

net/mlx5e: Always print health reporter message to dmesg 



[ Upstream commit 99cda45426c9a2c59bb2f7cb886a405440282455 ]

In case a reporter exists, error message is logged only to the devlink
tracer. The devlink tracer is a visibility utility only, which user can
choose not to monitor.
After cited patch, 3rd party monitoring tools that tracks these error
message will no longer find them in dmesg, causing a regression.

With this patch, error messages are also logged into the dmesg.

Fixes: c50de4af ("net/mlx5e: Generalize tx reporter's functionality")
Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a51aa28f

drivers/net/ethernet/mellanox/mlx5/core/en/health.c

+4 −3
Original line number Diff line number Diff line
@@ -197,9 +197,10 @@ int mlx5e_health_report(struct mlx5e_priv *priv, 
			struct devlink_health_reporter *reporter, char *err_str,

			struct mlx5e_err_ctx *err_ctx)

{

	if (!reporter) {

	netdev_err(priv->netdev, err_str);



	if (!reporter)

		return err_ctx->recover(&err_ctx->ctx);

	}



	return devlink_health_report(reporter, err_str, err_ctx);

}