Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bfc6e38 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Greg Kroah-Hartman
Browse files

media: v4l2-tpg: prevent the risk of a division by zero 



commit e6a3ea83fbe15d4818d01804e904cbb0e64e543b upstream.

As reported by Coverity, the logic at tpg_precalculate_line()
blindly rescales the buffer even when scaled_witdh is equal to
zero. If this ever happens, this will cause a division by zero.

Instead, add a WARN_ON_ONCE() to trigger such cases and return
without doing any precalculation.

Fixes: 63881df9 ("[media] vivid: add the Test Pattern Generator")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cad97ca8

drivers/media/common/v4l2-tpg/v4l2-tpg-core.c

+3 −0
Original line number Diff line number Diff line
@@ -1789,6 +1789,9 @@ static void tpg_precalculate_line(struct tpg_data *tpg) 
	unsigned p;

	unsigned x;



	if (WARN_ON_ONCE(!tpg->src_width || !tpg->scaled_width))

		return;



	switch (tpg->pattern) {

	case TPG_PAT_GREEN:

		contrast = TPG_COLOR_100_RED;