Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bf3dcfb authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed 



[ Upstream commit 1e42f82cbec7b2cc4873751e7791e6611901c5fc ]

It's not allowed to quit remove early without cleaning up completely.
Otherwise this results in resource leaks that probably yield graver
problems later. Here for example some tasklets might survive the lifetime
of the sprd-dma device and access sdev which is freed after .remove()
returns.

As none of the device freeing requires an active device, just ignore the
return value of pm_runtime_get_sync().

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarBaolin Wang <baolin.wang7@gmail.com>
Link: https://lore.kernel.org/r/20220721204054.323602-1-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d13b990d

drivers/dma/sprd-dma.c

+1 −4
Original line number Diff line number Diff line
@@ -1201,11 +1201,8 @@ static int sprd_dma_remove(struct platform_device *pdev) 
{

	struct sprd_dma_dev *sdev = platform_get_drvdata(pdev);

	struct sprd_dma_chn *c, *cn;

	int ret;



	ret = pm_runtime_get_sync(&pdev->dev);

	if (ret < 0)

		return ret;

	pm_runtime_get_sync(&pdev->dev);



	/* explicitly free the irq */

	if (sdev->irq > 0)