Commit 0b02e448 authored Dec 06, 2017 by Dave Young Committed by Ingo Molnar Dec 06, 2017

efi: Add comment to avoid future expanding of sysfs systab



/sys/firmware/efi/systab shows several different values, it breaks sysfs
one file one value design.  But since there are already userspace tools
depend on it eg. kexec-tools so add code comment to alert future expanding
of this file.

Signed-off-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20171206095010.24170-4-ard.biesheuvel@linaro.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 89c5a2d3

drivers/firmware/efi/efi.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -109,6 +109,8 @@ struct kobject *efi_kobj;
	/*		/*
	* Let's not leave out systab information that snuck into		* Let's not leave out systab information that snuck into
	* the efivars driver		* the efivars driver
			* Note, do not add more fields in systab sysfs file as it breaks sysfs
			* one value per file rule!
	*/		*/
	static ssize_t systab_show(struct kobject *kobj,		static ssize_t systab_show(struct kobject *kobj,
	struct kobj_attribute attr, char buf)		struct kobj_attribute attr, char buf)