Commit 0af4c8be authored Aug 21, 2018 by Trond Myklebust Committed by Anna Schumaker Aug 21, 2018

pNFS: Remove unwanted optimisation of layoutget

If we knew that the file was empty, we wouldn't be asking for a layout.
Any optimisation here is already done before calling pnfs_update_layout().
As it stands, we sometimes end up doing an unnecessary inband read to
the MDS even when holding a layout.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 1c1aeaf1

fs/nfs/pnfs.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1823,12 +1823,6 @@ pnfs_update_layout(struct inode *ino,
		goto out;
		}

		if (iomode == IOMODE_READ && i_size_read(ino) == 0) {
		trace_pnfs_update_layout(ino, pos, count, iomode, lo, lseg,
		PNFS_UPDATE_LAYOUT_RD_ZEROLEN);
		goto out;
		}

		if (pnfs_within_mdsthreshold(ctx, ino, iomode)) {
		trace_pnfs_update_layout(ino, pos, count, iomode, lo, lseg,
		PNFS_UPDATE_LAYOUT_MDSTHRESH);