Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ace64b8 authored by Or Gerlitz's avatar Or Gerlitz Committed by Roland Dreier
Browse files

IBiser: Fix wrong mask when sizeof (dma_addr_t) > sizeof (unsigned long) 



The code that prepares the SG associated with SCSI command for FMR was
buggy for systems with DMA addresses that don't fit in unsigned long,
e.g under the 32-bit based XenServer dom0 sizeof(dma_addr_t) is 8.

Fix that by casting to unsigned long long a masking constant used by
the code. This resolves a crash in iser_sg_to_page_vec on this system.

Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.co.il>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 322a8b03

drivers/infiniband/ulp/iser/iscsi_iser.h

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ 
	} while (0)



#define SHIFT_4K	12

#define SIZE_4K	(1UL << SHIFT_4K)

#define SIZE_4K	(1ULL << SHIFT_4K)

#define MASK_4K	(~(SIZE_4K-1))



					/* support up to 512KB in one RDMA */