Commit 0aade8f4 authored Apr 08, 2019 by Shahar S Matityahu Committed by Luca Coelho Apr 29, 2019

iwlwifi: avoid allocating memory for region with disabled domain



In iwl_fw_ini_get_trigger_len the driver allocates space for memory
regions regardless of their domain and in iwl_fw_ini_dump_trigger the
driver aborts trigger collection of disabled domain. This diff causes
unneeded memory allocation and traling zeros in the dump file.

Solve this behavior by enforcing domain checking in
iwl_fw_ini_get_trigger_len

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 391481ad

drivers/net/wireless/intel/iwlwifi/fw/dbg.c

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1751,6 +1751,10 @@ static int iwl_fw_ini_get_trigger_len(struct iwl_fw_runtime *fwrt,
	continue;		continue;
	}		}

			/* currently the driver supports always on domain only */
			if (le32_to_cpu(reg->domain) != IWL_FW_INI_DBG_DOMAIN_ALWAYS_ON)
			continue;

	switch (le32_to_cpu(reg->region_type)) {		switch (le32_to_cpu(reg->region_type)) {
	case IWL_FW_INI_REGION_DEVICE_MEMORY:		case IWL_FW_INI_REGION_DEVICE_MEMORY:
	case IWL_FW_INI_REGION_PERIPHERY_MAC:		case IWL_FW_INI_REGION_PERIPHERY_MAC: